correct the calculation of z positions of clusters and docaclusters#1165
correct the calculation of z positions of clusters and docaclusters#1165zyzhangjlab wants to merge 4 commits intoJeffersonLab:developmentfrom
Conversation
|
I think @hauenst mentioned this is related to geometry consistency between simulation and reconstruction? |
| Hit h = pc.get_hits_list().get(0); | ||
| return h.getLine(); | ||
| } | ||
| public static double getStereoAngleDeg(int superlayerId) { |
There was a problem hiding this comment.
Why is this here? This is not using "single source of geometry" information.
There was a problem hiding this comment.
I mean to get the origin and end z position from geometry with one line from one precluster.
There was a problem hiding this comment.
@zyzhangjlab I think it is about the stereo angles. Can you find a way to retrieve them using only the geometry? We don't want hard coded values.
There was a problem hiding this comment.
@ftouchte I see I can calculate them using only the geometry. I will do this later.
zyzhangjlab
requested review from
N-Plx,
baltzell,
efuchey,
mathieuouillon and
mpaolone
as code owners
mathieuouillon
left a comment
mathieuouillon
left a comment
There was a problem hiding this comment.
Look good, just remove the unused variables
| private double _StereoAngle = 20.0; | ||
| private double _DeltaZ = 300.0; | ||
| private double _Zoffset = 150.0; | ||
| private double _StereoAngle = 20.0;//not used |
There was a problem hiding this comment.
If these variables are not used anywhere, they should be removed (lines 17 to 19)
5 participants
No description provided.